Skip to content

Simplify ObjectValue #4933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 25, 2021
Merged

Simplify ObjectValue #4933

merged 11 commits into from
May 25, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented May 22, 2021 •
edited
Loading

This is one of those "port of port" PRs. When I implemented iOS (firebase/firebase-ios-sdk#8124) it became apparent that we do not need overlays anymore to implement mutable ObjectValues. There are only needed on Android, since Protobuf manipulations on Android are fairly expensive. On iOS and Web, we can directly edit the Protobuf object and can use a simpler version of ObjectValue.

@changeset-bot
Copy link

changeset-bot bot commented May 22, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: c8a3f69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 22, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 296 kB 296 kB +41 B (+0.0%)
    esm2017 265 kB 265 kB +41 B (+0.0%)
    main 299 kB 299 kB +41 B (+0.0%)
    module 296 kB 296 kB +41 B (+0.0%)

  • @firebase/database-exp

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 246 kB 246 kB +41 B (+0.0%)
    main 278 kB 278 kB +41 B (+0.0%)
    module 246 kB 246 kB +41 B (+0.0%)

  • @firebase/firestore

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 284 kB 284 kB +157 B (+0.1%)
    esm2017 226 kB 226 kB +159 B (+0.1%)
    main 531 kB 531 kB +17 B (+0.0%)
    module 284 kB 284 kB +157 B (+0.1%)
    react-native 226 kB 226 kB +159 B (+0.1%)

  • @firebase/firestore-exp

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 224 kB 224 kB +160 B (+0.1%)
    main 510 kB 510 kB +17 B (+0.0%)
    module 224 kB 224 kB +160 B (+0.1%)
    react-native 224 kB 224 kB +159 B (+0.1%)

  • @firebase/firestore-lite

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 72.4 kB 72.6 kB +178 B (+0.2%)
    main 149 kB 149 kB +33 B (+0.0%)
    module 72.4 kB 72.6 kB +178 B (+0.2%)
    react-native 72.6 kB 72.8 kB +178 B (+0.2%)

  • @firebase/firestore/bundle

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 290 kB 290 kB +161 B (+0.1%)
    esm2017 176 kB 176 kB +163 B (+0.1%)
    main 527 kB 527 kB +17 B (+0.0%)
    module 290 kB 290 kB +161 B (+0.1%)
    react-native 176 kB 177 kB +163 B (+0.1%)

  • @firebase/firestore/memory

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 216 kB 216 kB +165 B (+0.1%)
    esm2017 172 kB 172 kB +163 B (+0.1%)
    main 325 kB 325 kB +31 B (+0.0%)
    module 216 kB 216 kB +165 B (+0.1%)
    react-native 172 kB 172 kB +163 B (+0.1%)

  • @firebase/firestore/memory-bundle

    Type Base (6ced917) Head (74b8f1c) Diff
    browser 224 kB 224 kB +165 B (+0.1%)
    esm2017 176 kB 176 kB +163 B (+0.1%)
    main 322 kB 322 kB +31 B (+0.0%)
    module 224 kB 224 kB +165 B (+0.1%)
    react-native 176 kB 177 kB +163 B (+0.1%)

  • firebase

    Click to show 15 binary size changes.
    Type Base (6ced917) Head (74b8f1c) Diff
    firebase-analytics.js 35.8 kB 35.7 kB -16 B (-0.0%)
    firebase-app-check.js 22.2 kB 22.2 kB -34 B (-0.2%)
    firebase-app.js 21.8 kB 21.8 kB -42 B (-0.2%)
    firebase-auth.js 177 kB 177 kB -21 B (-0.0%)
    firebase-database.js 187 kB 187 kB -91 B (-0.0%)
    firebase-firestore.js 332 kB 332 kB +105 B (+0.0%)
    firebase-firestore.memory.js 267 kB 267 kB +121 B (+0.0%)
    firebase-functions.js 10.8 kB 10.8 kB +4 B (+0.0%)
    firebase-installations.js 19.3 kB 19.3 kB +5 B (+0.0%)
    firebase-messaging.js 41.0 kB 40.9 kB -100 B (-0.2%)
    firebase-performance-standalone.js 49.7 kB 49.6 kB -48 B (-0.1%)
    firebase-performance.js 38.3 kB 38.3 kB -6 B (-0.0%)
    firebase-remote-config.js 36.9 kB 36.9 kB +5 B (+0.0%)
    firebase-storage.js 41.6 kB 41.5 kB -56 B (-0.1%)
    firebase.js 889 kB 888 kB -188 B (-0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 22, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (6ced917) and head commit (74b8f1c).

@schmidt-sebastian schmidt-sebastian removed the request for review from thebrianchen May 24, 2021 16:57
thebrianchen
thebrianchen approved these changes May 25, 2021
View reviewed changes
packages/firestore/src/model/object_value.ts Outdated
*
* This method applies any outstanding modifications and memoizes the result.
* Further invocations are based on this memoized result.
* Modifies `parent_map` by adding, replacing or deleting the specified
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/parent_map/fieldsMap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@schmidt-sebastian schmidt-sebastian merged commit 4091720 into master May 25, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/simplifyport branch May 25, 2021 17:23
@firebase firebase locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @thebrianchen